From cd117ed22825b8f442e0f2281678f4549be3e109 Mon Sep 17 00:00:00 2001
From: 648540858 <648540858@qq.com>
Date: 星期五, 23 九月 2022 23:15:39 +0800
Subject: [PATCH] dialog去除以及异常情况处理优化

---
 src/main/java/com/genersoft/iot/vmp/gb28181/transmit/event/request/impl/message/response/cmd/CatalogResponseMessageHandler.java |  148 ++++++++++++++++++++++---------------------------
 1 files changed, 66 insertions(+), 82 deletions(-)

diff --git a/src/main/java/com/genersoft/iot/vmp/gb28181/transmit/event/request/impl/message/response/cmd/CatalogResponseMessageHandler.java b/src/main/java/com/genersoft/iot/vmp/gb28181/transmit/event/request/impl/message/response/cmd/CatalogResponseMessageHandler.java
index 3cff19d..94fed56 100644
--- a/src/main/java/com/genersoft/iot/vmp/gb28181/transmit/event/request/impl/message/response/cmd/CatalogResponseMessageHandler.java
+++ b/src/main/java/com/genersoft/iot/vmp/gb28181/transmit/event/request/impl/message/response/cmd/CatalogResponseMessageHandler.java
@@ -87,89 +87,73 @@
     public void handForDevice(RequestEvent evt, Device device, Element element) {
         taskQueue.offer(new HandlerCatchData(evt, device, element));
         // 鍥炲200 OK
+        ServerTransaction serverTransaction = getServerTransaction(evt);
         try {
-            ServerTransaction serverTransaction = getServerTransaction(evt);
             responseAck(serverTransaction, Response.OK);
-            if (!taskQueueHandlerRun) {
-                taskQueueHandlerRun = true;
-                taskExecutor.execute(()-> {
-                    while (!taskQueue.isEmpty()) {
-                        HandlerCatchData take = taskQueue.poll();
-                        try {
-                            Element rootElement = getRootElement(take.getEvt(), take.getDevice().getCharset());
-                            if (rootElement == null) {
-                                logger.warn("[ 鏀跺埌閫氶亾 ] content cannot be null, {}", evt.getRequest());
-                                continue;
-                            }
-                            Element deviceListElement = rootElement.element("DeviceList");
-                            Element sumNumElement = rootElement.element("SumNum");
-                            Element snElement = rootElement.element("SN");
-                            if (snElement == null || sumNumElement == null || deviceListElement == null) {
-                                responseAck(serverTransaction, Response.BAD_REQUEST, "xml error");
-                                continue;
-                            }
-                            int sumNum = Integer.parseInt(sumNumElement.getText());
-
-                            if (sumNum == 0) {
-                                logger.info("[鏀跺埌閫氶亾]璁惧:{}鐨�: 0涓�", take.getDevice().getDeviceId());
-                                // 鏁版嵁宸茬粡瀹屾暣鎺ユ敹
-                                storager.cleanChannelsForDevice(take.getDevice().getDeviceId());
-                                catalogDataCatch.setChannelSyncEnd(take.getDevice().getDeviceId(), null);
-                            }else {
-                                Iterator<Element> deviceListIterator = deviceListElement.elementIterator();
-                                if (deviceListIterator != null) {
-                                    List<DeviceChannel> channelList = new ArrayList<>();
-                                    // 閬嶅巻DeviceList
-                                    while (deviceListIterator.hasNext()) {
-                                        Element itemDevice = deviceListIterator.next();
-                                        Element channelDeviceElement = itemDevice.element("DeviceID");
-                                        if (channelDeviceElement == null) {
-                                            continue;
-                                        }
-                                        DeviceChannel deviceChannel = XmlUtil.channelContentHander(itemDevice, device, null);
-                                        deviceChannel.setDeviceId(take.getDevice().getDeviceId());
-
-                                        channelList.add(deviceChannel);
-                                    }
-                                    int sn = Integer.parseInt(snElement.getText());
-                                    catalogDataCatch.put(take.getDevice().getDeviceId(), sn, sumNum, take.getDevice(), channelList);
-                                    logger.info("[鏀跺埌閫氶亾]璁惧: {} -> {}涓紝{}/{}", take.getDevice().getDeviceId(), channelList.size(), catalogDataCatch.get(take.getDevice().getDeviceId()) == null ? 0 :catalogDataCatch.get(take.getDevice().getDeviceId()).size(), sumNum);
-                                    if (catalogDataCatch.get(take.getDevice().getDeviceId()).size() == sumNum) {
-                                        // 鏁版嵁宸茬粡瀹屾暣鎺ユ敹锛� 姝ゆ椂鍙兘瀛樺湪鏌愪釜璁惧绂荤嚎鍙樹笂绾跨殑鎯呭喌锛屼絾鏄�冭檻鍒版�ц兘锛屾澶勪笉鍋氬鐞嗭紝
-                                        // 鐩墠鏀寔璁惧閫氶亾涓婄嚎閫氱煡鏃跺拰璁惧涓婄嚎鏃跺悜涓婄骇閫氱煡
-                                        boolean resetChannelsResult = storager.resetChannels(take.getDevice().getDeviceId(), catalogDataCatch.get(take.getDevice().getDeviceId()));
-                                        if (!resetChannelsResult) {
-                                            String errorMsg = "鎺ユ敹鎴愬姛锛屽啓鍏ュけ璐ワ紝鍏�" + sumNum + "鏉★紝宸叉帴鏀�" + catalogDataCatch.get(take.getDevice().getDeviceId()).size() + "鏉�";
-                                            catalogDataCatch.setChannelSyncEnd(take.getDevice().getDeviceId(), errorMsg);
-                                        }else {
-                                            catalogDataCatch.setChannelSyncEnd(take.getDevice().getDeviceId(), null);
-                                        }
-                                    }
-                                }
-
-                            }
-                        } catch (DocumentException e) {
-                            e.printStackTrace();
-                        } catch (InvalidArgumentException e) {
-                            e.printStackTrace();
-                        } catch (ParseException e) {
-                            e.printStackTrace();
-                        } catch (SipException e) {
-                            e.printStackTrace();
-                        } finally {
-                            taskQueueHandlerRun = false;
-                        }
+        } catch (SipException | InvalidArgumentException | ParseException e) {
+            logger.error("[鍛戒护鍙戦�佸け璐 鐩綍鏌ヨ鍥炲: {}", e.getMessage());
+        }
+        if (!taskQueueHandlerRun) {
+            taskQueueHandlerRun = true;
+            taskExecutor.execute(() -> {
+                while (!taskQueue.isEmpty()) {
+                    HandlerCatchData take = taskQueue.poll();
+                    Element rootElement = null;
+                    try {
+                        rootElement = getRootElement(take.getEvt(), take.getDevice().getCharset());
+                    } catch (DocumentException e) {
+                        logger.error("[xml瑙f瀽] 澶辫触锛� ", e);
+                        continue;
                     }
-                });
-            }
-        } catch (SipException e) {
-            throw new RuntimeException(e);
-        } catch (InvalidArgumentException e) {
-            throw new RuntimeException(e);
-        } catch (ParseException e) {
-            throw new RuntimeException(e);
-        } finally {
-            taskQueueHandlerRun = false;
+                    if (rootElement == null) {
+                        logger.warn("[ 鏀跺埌閫氶亾 ] content cannot be null, {}", evt.getRequest());
+                        continue;
+                    }
+                    Element deviceListElement = rootElement.element("DeviceList");
+                    Element sumNumElement = rootElement.element("SumNum");
+                    Element snElement = rootElement.element("SN");
+                    int sumNum = Integer.parseInt(sumNumElement.getText());
+
+                    if (sumNum == 0) {
+                        logger.info("[鏀跺埌閫氶亾]璁惧:{}鐨�: 0涓�", take.getDevice().getDeviceId());
+                        // 鏁版嵁宸茬粡瀹屾暣鎺ユ敹
+                        storager.cleanChannelsForDevice(take.getDevice().getDeviceId());
+                        catalogDataCatch.setChannelSyncEnd(take.getDevice().getDeviceId(), null);
+                    } else {
+                        Iterator<Element> deviceListIterator = deviceListElement.elementIterator();
+                        if (deviceListIterator != null) {
+                            List<DeviceChannel> channelList = new ArrayList<>();
+                            // 閬嶅巻DeviceList
+                            while (deviceListIterator.hasNext()) {
+                                Element itemDevice = deviceListIterator.next();
+                                Element channelDeviceElement = itemDevice.element("DeviceID");
+                                if (channelDeviceElement == null) {
+                                    continue;
+                                }
+                                DeviceChannel deviceChannel = XmlUtil.channelContentHander(itemDevice, device, null);
+                                deviceChannel.setDeviceId(take.getDevice().getDeviceId());
+
+                                channelList.add(deviceChannel);
+                            }
+                            int sn = Integer.parseInt(snElement.getText());
+                            catalogDataCatch.put(take.getDevice().getDeviceId(), sn, sumNum, take.getDevice(), channelList);
+                            logger.info("[鏀跺埌閫氶亾]璁惧: {} -> {}涓紝{}/{}", take.getDevice().getDeviceId(), channelList.size(), catalogDataCatch.get(take.getDevice().getDeviceId()) == null ? 0 : catalogDataCatch.get(take.getDevice().getDeviceId()).size(), sumNum);
+                            if (catalogDataCatch.get(take.getDevice().getDeviceId()).size() == sumNum) {
+                                // 鏁版嵁宸茬粡瀹屾暣鎺ユ敹锛� 姝ゆ椂鍙兘瀛樺湪鏌愪釜璁惧绂荤嚎鍙樹笂绾跨殑鎯呭喌锛屼絾鏄�冭檻鍒版�ц兘锛屾澶勪笉鍋氬鐞嗭紝
+                                // 鐩墠鏀寔璁惧閫氶亾涓婄嚎閫氱煡鏃跺拰璁惧涓婄嚎鏃跺悜涓婄骇閫氱煡
+                                boolean resetChannelsResult = storager.resetChannels(take.getDevice().getDeviceId(), catalogDataCatch.get(take.getDevice().getDeviceId()));
+                                if (!resetChannelsResult) {
+                                    String errorMsg = "鎺ユ敹鎴愬姛锛屽啓鍏ュけ璐ワ紝鍏�" + sumNum + "鏉★紝宸叉帴鏀�" + catalogDataCatch.get(take.getDevice().getDeviceId()).size() + "鏉�";
+                                    catalogDataCatch.setChannelSyncEnd(take.getDevice().getDeviceId(), errorMsg);
+                                } else {
+                                    catalogDataCatch.setChannelSyncEnd(take.getDevice().getDeviceId(), null);
+                                }
+                            }
+                        }
+
+                    }
+                }
+            });
         }
 
     }
@@ -182,7 +166,7 @@
     public SyncStatus getChannelSyncProgress(String deviceId) {
         if (catalogDataCatch.get(deviceId) == null) {
             return null;
-        }else {
+        } else {
             return catalogDataCatch.getSyncStatus(deviceId);
         }
     }
@@ -190,7 +174,7 @@
     public boolean isSyncRunning(String deviceId) {
         if (catalogDataCatch.get(deviceId) == null) {
             return false;
-        }else {
+        } else {
             return catalogDataCatch.isSyncRunning(deviceId);
         }
     }

--
Gitblit v1.8.0