From df11956c3c203434d3ef54955a502c466f1382dd Mon Sep 17 00:00:00 2001
From: 64850858 <648540858@qq.com>
Date: 星期一, 07 六月 2021 15:42:01 +0800
Subject: [PATCH] 取出错误配置

---
 src/main/java/com/genersoft/iot/vmp/gb28181/transmit/request/impl/RegisterRequestProcessor.java |   62 ++++++++++++++++++------------
 1 files changed, 37 insertions(+), 25 deletions(-)

diff --git a/src/main/java/com/genersoft/iot/vmp/gb28181/transmit/request/impl/RegisterRequestProcessor.java b/src/main/java/com/genersoft/iot/vmp/gb28181/transmit/request/impl/RegisterRequestProcessor.java
index 22d54a7..64be7ef 100644
--- a/src/main/java/com/genersoft/iot/vmp/gb28181/transmit/request/impl/RegisterRequestProcessor.java
+++ b/src/main/java/com/genersoft/iot/vmp/gb28181/transmit/request/impl/RegisterRequestProcessor.java
@@ -2,7 +2,10 @@
 
 import java.security.NoSuchAlgorithmException;
 import java.text.ParseException;
+import java.text.SimpleDateFormat;
+import java.time.LocalDateTime;
 import java.util.Calendar;
+import java.util.Date;
 import java.util.Locale;
 
 import javax.sip.InvalidArgumentException;
@@ -17,7 +20,9 @@
 import javax.sip.message.Response;
 
 import com.genersoft.iot.vmp.gb28181.bean.WvpSipDate;
+import gov.nist.javax.sip.RequestEventExt;
 import gov.nist.javax.sip.header.SIPDateHeader;
+import gov.nist.javax.sip.message.SIPRequest;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.util.StringUtils;
@@ -59,28 +64,37 @@
 	@Override
 	public void process(RequestEvent evt) {
 		try {
-			logger.info("鏀跺埌娉ㄥ唽璇锋眰锛屽紑濮嬪鐞�");
+			RequestEventExt evtExt = (RequestEventExt)evt;
+			String requestAddress = evtExt.getRemoteIpAddress() + ":" + evtExt.getRemotePort();
+			logger.info("[{}] 鏀跺埌娉ㄥ唽璇锋眰锛屽紑濮嬪鐞�", requestAddress);
 			Request request = evt.getRequest();
 
 			Response response = null; 
 			boolean passwordCorrect = false;
 			// 娉ㄥ唽鏍囧織  0锛氭湭鎼哄甫鎺堟潈澶存垨鑰呭瘑鐮侀敊璇�  1锛氭敞鍐屾垚鍔�   2锛氭敞閿�鎴愬姛
 			int registerFlag = 0;
-			Device device = null;
+			FromHeader fromHeader = (FromHeader) request.getHeader(FromHeader.NAME);
+			AddressImpl address = (AddressImpl) fromHeader.getAddress();
+			SipUri uri = (SipUri) address.getURI();
+			String deviceId = uri.getUser();
+			Device device = storager.queryVideoDevice(deviceId);
 			AuthorizationHeader authorhead = (AuthorizationHeader) request.getHeader(AuthorizationHeader.NAME); 
 			// 鏍¢獙瀵嗙爜鏄惁姝g‘
 			if (authorhead != null) {
 				passwordCorrect = new DigestServerAuthenticationHelper().doAuthenticatePlainTextPassword(request,
 						sipConfig.getSipPassword());
 			}
+			if (StringUtils.isEmpty(sipConfig.getSipPassword())){
+				passwordCorrect = true;
+			}
 
 			// 鏈惡甯︽巿鏉冨ご鎴栬�呭瘑鐮侀敊璇� 鍥炲401
 			if (authorhead == null || !passwordCorrect) {
 				
 				if (authorhead == null) {
-					logger.info("鏈惡甯︽巿鏉冨ご 鍥炲401");
+					logger.info("[{}] 鏈惡甯︽巿鏉冨ご 鍥炲401", requestAddress);
 				} else if (!passwordCorrect) {
-					logger.info("瀵嗙爜閿欒 鍥炲401");
+					logger.info("[{}] 瀵嗙爜閿欒 鍥炲401", requestAddress);
 				}
 				response = getMessageFactory().createResponse(Response.UNAUTHORIZED, request);
 				new DigestServerAuthenticationHelper().generateChallenge(getHeaderFactory(), response, sipConfig.getSipDomain());
@@ -96,38 +110,42 @@
 				response.addHeader(dateHeader);
 
 				ExpiresHeader expiresHeader = (ExpiresHeader) request.getHeader(Expires.NAME);
+				if (expiresHeader == null) {
+					response = getMessageFactory().createResponse(Response.BAD_REQUEST, request);
+					getServerTransaction(evt).sendResponse(response);
+					return;
+				}
 				// 娣诲姞Contact澶�
 				response.addHeader(request.getHeader(ContactHeader.NAME));
 				// 娣诲姞Expires澶�
 				response.addHeader(request.getExpires());
 				
-				// 1.鑾峰彇鍒伴�氫俊鍦板潃绛変俊鎭紝淇濆瓨鍒癛edis
-				FromHeader fromHeader = (FromHeader) request.getHeader(FromHeader.NAME);
+				// 鑾峰彇鍒伴�氫俊鍦板潃绛変俊鎭�
 				ViaHeader viaHeader = (ViaHeader) request.getHeader(ViaHeader.NAME);
 				String received = viaHeader.getReceived();
 				int rPort = viaHeader.getRPort();
-				// 鏈湴妯℃嫙璁惧 received 涓虹┖ rPort 涓� -1
 				// 瑙f瀽鏈湴鍦板潃鏇夸唬
 				if (StringUtils.isEmpty(received) || rPort == -1) {
 					received = viaHeader.getHost();
 					rPort = viaHeader.getPort();
 				}
 				//
-				AddressImpl address = (AddressImpl) fromHeader.getAddress();
-				SipUri uri = (SipUri) address.getURI();
-				String deviceId = uri.getUser();
-				device = new Device();
-				device.setStreamMode("UDP");
-				device.setDeviceId(deviceId);
+
+				if (device == null) {
+					device = new Device();
+					device.setStreamMode("UDP");
+					device.setDeviceId(deviceId);
+				}
 				device.setIp(received);
 				device.setPort(rPort);
 				device.setHostAddress(received.concat(":").concat(String.valueOf(rPort)));
 				// 娉ㄩ攢鎴愬姛
-				if (expiresHeader != null && expiresHeader.getExpires() == 0) {
+				if (expiresHeader.getExpires() == 0) {
 					registerFlag = 2;
 				}
 				// 娉ㄥ唽鎴愬姛
 				else {
+					device.setExpires(expiresHeader.getExpires());
 					registerFlag = 1;
 					// 鍒ゆ柇TCP杩樻槸UDP
 					boolean isTcp = false;
@@ -143,19 +161,13 @@
 			// 娉ㄥ唽鎴愬姛
 			// 淇濆瓨鍒皉edis
 			// 涓嬪彂catelog鏌ヨ鐩綍
-			if (registerFlag == 1 && device != null) {
-				logger.info("娉ㄥ唽鎴愬姛! deviceId:" + device.getDeviceId());
-				// boolean exists = storager.exists(device.getDeviceId());
-				device.setRegisterTimeMillis(System.currentTimeMillis());
-				storager.updateDevice(device);
-				publisher.onlineEventPublish(device.getDeviceId(), VideoManagerConstants.EVENT_ONLINE_REGISTER);
-
+			if (registerFlag == 1 ) {
+				logger.info("[{}] 娉ㄥ唽鎴愬姛! deviceId:" + device.getDeviceId(), requestAddress);
+				publisher.onlineEventPublish(device, VideoManagerConstants.EVENT_ONLINE_REGISTER);
 				// 閲嶆柊娉ㄥ唽鏇存柊璁惧鍜岄�氶亾锛屼互鍏嶈澶囨浛鎹㈡垨鏇存柊鍚庝俊鎭棤娉曟洿鏂�
-				//if (!exists) {
-					handler.onRegister(device);
-				//}
+				handler.onRegister(device);
 			} else if (registerFlag == 2) {
-				logger.info("娉ㄩ攢鎴愬姛! deviceId:" + device.getDeviceId());
+				logger.info("[{}] 娉ㄩ攢鎴愬姛! deviceId:" + device.getDeviceId(), requestAddress);
 				publisher.outlineEventPublish(device.getDeviceId(), VideoManagerConstants.EVENT_OUTLINE_UNREGISTER);
 			}
 		} catch (SipException | InvalidArgumentException | NoSuchAlgorithmException | ParseException e) {

--
Gitblit v1.8.0